Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 23461024: Rewrite negative test number_identifier_negative_test.dart to multi-test (Closed)

Created:
7 years, 3 months ago by Søren Gjesse
Modified:
7 years, 3 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rewrite negative test number_identifier_negative_test.dart to multi-test R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27105

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M tests/language/language_analyzer.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +4 lines, -3 lines 0 comments Download
D tests/language/number_identifier_negative_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
A + tests/language/number_identifier_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 3 months ago (2013-09-04 09:02:27 UTC) #1
kustermann
LGTM -- don't forget to replace XXX.
7 years, 3 months ago (2013-09-04 09:19:49 UTC) #2
Søren Gjesse
On 2013/09/04 09:19:49, kustermann wrote: > LGTM -- don't forget to replace XXX. Issue number ...
7 years, 3 months ago (2013-09-04 09:39:15 UTC) #3
Søren Gjesse
7 years, 3 months ago (2013-09-04 09:40:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698