Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 23461019: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 3 months ago by scheglov
Modified:
7 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

New analyzer_experimental snapshot. And java2dart improvements for better inner classes support. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27078

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4341 lines, -1078 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl2.java View 2 chunks +2 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 1 chunk +3 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 5 chunks +60 lines, -10 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 4 chunks +7 lines, -2 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 1 chunk +90 lines, -0 lines 1 comment Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 16 chunks +4026 lines, -1023 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 5 chunks +12 lines, -11 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 2 chunks +42 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 4 chunks +73 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 3 months ago (2013-09-03 20:49:58 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/23461019/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java (right): https://codereview.chromium.org/23461019/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java#newcode191 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java:191: // XXX Do you still need this marker? ...
7 years, 3 months ago (2013-09-03 21:11:05 UTC) #2
scheglov
7 years, 3 months ago (2013-09-03 21:46:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27078 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698