Make hidden initializing formal parameters invisible to the debugger

Make hidden initializing formal parameters invisible to the debugger

Fixes issue 13143.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27505

[regis, 2013-09-13 18:38:45]

LGTM

I guess it is not possible/easy to add a regression test?

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:444: LocalVariable* var;      // Scope variable allocated
for this parameter.
Do not align comment.

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/scopes.cc
File runtime/vm/scopes.cc (right):

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/scopes.cc#newco...
runtime/vm/scopes.cc:223: // Add variables that are declared in this scope to
vars, then collect
Add visible variables ...

[hausner, 2013-09-13 21:32:16]

A test is possible but adds too much testing runtime and is not worth it IMO.

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/parser.cc#newco...
runtime/vm/parser.cc:444: LocalVariable* var;      // Scope variable allocated
for this parameter.
On 2013/09/13 18:38:45, regis wrote:
> Do not align comment.

Done.

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/scopes.cc
File runtime/vm/scopes.cc (right):

https://codereview.chromium.org/23460040/diff/5001/runtime/vm/scopes.cc#newco...
runtime/vm/scopes.cc:223: // Add variables that are declared in this scope to
vars, then collect
On 2013/09/13 18:38:45, regis wrote:
> Add visible variables ...

Done.

[hausner, 2013-09-13 21:37:21]

Committed patchset #3 manually as r27505 (presubmit successful).