Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 23460019: Optimization for Element.innerHtml (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Optimization for Element.innerHtml Basically we were creating a new range every time HTML needs to be parsed, which is unnecessary and turns out to be quite expensive. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=27259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 3 months ago (2013-09-06 17:39:11 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-09-06 18:26:46 UTC) #2
blois
7 years, 3 months ago (2013-09-06 19:13:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698