Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 23458038: Ensure formatted CUs end with a newline (dartbug.com/13188). (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure formatted CUs end with a newline (dartbug.com/13188). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=27352

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -26 lines) Patch
M pkg/analyzer_experimental/lib/src/services/formatter_impl.dart View 1 3 chunks +12 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/services/writer.dart View 1 4 chunks +25 lines, -18 lines 0 comments Download
M pkg/analyzer_experimental/test/services/formatter_test.dart View 7 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
7 years, 3 months ago (2013-09-10 21:09:27 UTC) #1
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-10 21:16:24 UTC) #2
pquitslund
7 years, 3 months ago (2013-09-10 21:17:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r27352 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698