Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 23458017: Add null literals to polymer expressions (Closed)

Created:
7 years, 3 months ago by justinfagnani
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M pkg/polymer_expressions/lib/eval.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/polymer_expressions/lib/parser.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/test/eval_test.dart View 1 3 chunks +10 lines, -0 lines 0 comments Download
M pkg/polymer_expressions/test/parser_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
justinfagnani
This is the right one :)
7 years, 3 months ago (2013-09-03 21:39:33 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart File pkg/polymer_expressions/test/eval_test.dart (right): https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart#newcode171 pkg/polymer_expressions/test/eval_test.dart:171: expectEval('true && null', false, null); ... you don't ...
7 years, 3 months ago (2013-09-03 21:47:24 UTC) #2
justinfagnani
https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart File pkg/polymer_expressions/test/eval_test.dart (right): https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart#newcode171 pkg/polymer_expressions/test/eval_test.dart:171: expectEval('true && null', false, null); On 2013/09/03 21:47:24, John ...
7 years, 3 months ago (2013-09-03 21:54:35 UTC) #3
Chris Bracken
lgtm https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart File pkg/polymer_expressions/test/eval_test.dart (right): https://codereview.chromium.org/23458017/diff/1/pkg/polymer_expressions/test/eval_test.dart#newcode77 pkg/polymer_expressions/test/eval_test.dart:77: expectEval('1 == null', false); != test for the ...
7 years, 3 months ago (2013-09-03 21:55:39 UTC) #4
justinfagnani
7 years, 3 months ago (2013-09-06 20:00:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27263 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698