Issue 23458008: Fix bug with reflection on VM-internal native methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23458008: Fix bug with reflection on VM-internal native methods. (Closed)

Created:
7 years, 3 months ago by Florian Schneider

Modified:
7 years, 3 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug with reflection on VM-internal native methods. My previous approach was not enough, since methods can be invoked via reflection before they are parsed/compiled. This CL fixes the problem at hand, but I'd like a more general approach to mark those methods. Maybe an annotation at the declaration would be better. I also refactored the test case as suggested in the previous code review. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=27009

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -23 lines)			Patch
M	runtime/vm/object.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/vm/reflect_core_vm_test.dart	View	1 chunk	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM. Would it be possible to detect invisible (private, internal lib) functions in Parser::ParseTopLevelFunction?

7 years, 3 months ago (2013-08-29 15:47:48 UTC) #2

Florian Schneider

7 years, 3 months ago (2013-09-02 10:44:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27009 (presubmit successful).

Expand Messages | Collapse Messages