Issue 23454032: - Tighten assertions in the X64 assembler related to object pool usage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23454032: - Tighten assertions in the X64 assembler related to object pool usage. (Closed)

Created:
7 years, 3 months ago by Ivan Posva

Modified:
7 years, 3 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Tighten assertions in the X64 assembler related to object pool usage. - Adjust code passing objects into the assembler. - Fix stack smashing bug in test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=27445

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -53 lines)			Patch
M	runtime/vm/assembler_x64.cc	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	11 chunks	+12 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	22 chunks	+22 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

7 years, 3 months ago (2013-09-12 20:44:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27445 (presubmit successful).