Issue 23454012: Adding conversion support for JSON XHR requests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23454012: Adding conversion support for JSON XHR requests. (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Emily Fortuna, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adding conversion support for JSON XHR requests. This has been a half-supported feature for Chrome for a while, but popular elsewhere. Appears that recent Dartium behavior broke, so adding a test, but still need to fix Dartium. BUG=13069 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=27215

Patch Set 1 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+10 lines, -1 line	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/xhr_test.dart	View	3 chunks	+24 lines, -4 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_Conversions.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 3 months ago (2013-09-05 22:02:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27215 (presubmit successful).

Expand Messages | Collapse Messages