Keep track of type parameter processing in mixin application classes.

Keep track of the application of a mixin type to a mixin application class,
which includes setting up its type parameters (fix issue 12871).

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27157

[siva, 2013-09-04 21:07:00]

lgtm

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:514: if (cls.mixin() != Type::null()) {
Might be more readable to have a isMixin() method in 'class Class' which does
this check. I think this check is also used elsewhere.

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:1659: if ((mixin() != Type::null()) &&
!is_mixin_type_applied()) {
See comment on isMixin() method.

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.h#newcod...
runtime/vm/object.h:1029: kClassFinalizedBit = 6,
I think this should be kClassFinalizedBits as we have 2

[regis, 2013-09-04 22:14:27]

Thanks Siva!

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/class_finalizer...
runtime/vm/class_finalizer.cc:514: if (cls.mixin() != Type::null()) {
On 2013/09/04 21:07:00, siva wrote:
> Might be more readable to have a isMixin() method in 'class Class' which does
> this check. I think this check is also used elsewhere.

Added IsMixinApplication() to class Class.

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:1659: if ((mixin() != Type::null()) &&
!is_mixin_type_applied()) {
On 2013/09/04 21:07:00, siva wrote:
> See comment on isMixin() method.

Done.

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/23453024/diff/9001/runtime/vm/object.h#newcod...
runtime/vm/object.h:1029: kClassFinalizedBit = 6,
On 2013/09/04 21:07:00, siva wrote:
> I think this should be kClassFinalizedBits as we have 2

Done.

[regis, 2013-09-04 22:21:40]

Committed patchset #4 manually as r27157 (presubmit successful).