Issue 23452055: Address comments of committed change https://codereview.chromium.org/24397002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23452055: Address comments of committed change https://codereview.chromium.org/24397002/ (Closed)

Created:
7 years, 3 months ago by regis

Modified:
7 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -32 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	6 chunks	+80 lines, -22 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

hausner

LGTM. Thank you for fixing the typo. The perils of copy-paste :)

7 years, 2 months ago (2013-09-24 20:17:14 UTC) #2

regis

7 years, 2 months ago (2013-09-24 20:26:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27850 (presubmit successful).