Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23452029: Address comments from CL 23304012. (Closed)

Created:
7 years, 3 months ago by ahe
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : emitConvertToFastObjectFunction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 6 chunks +13 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3735 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3735: void emitInstancify() { Nicolas suggested renaming this method, but ...
7 years, 3 months ago (2013-09-13 09:36:14 UTC) #1
ngeoffray
LGTM! Thank you https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3774 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3774: // fast objects by calling "instancify". ...
7 years, 3 months ago (2013-09-13 10:05:54 UTC) #2
ahe
https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/23452029/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode3735 dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:3735: void emitInstancify() { On 2013/09/13 09:36:14, ahe wrote: > ...
7 years, 3 months ago (2013-09-13 10:09:12 UTC) #3
ahe
7 years, 3 months ago (2013-09-13 10:11:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r27470 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698