Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 23451046: Formatter stdin processing support. (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years, 3 months ago (2013-09-11 18:48:45 UTC) #1
scheglov
LGTM https://codereview.chromium.org/23451046/diff/1/pkg/analyzer_experimental/bin/formatter.dart File pkg/analyzer_experimental/bin/formatter.dart (right): https://codereview.chromium.org/23451046/diff/1/pkg/analyzer_experimental/bin/formatter.dart#newcode81 pkg/analyzer_experimental/bin/formatter.dart:81: .listen((String data) => input.write(data), AFAIK code style (or ...
7 years, 3 months ago (2013-09-11 18:52:42 UTC) #2
pquitslund
https://codereview.chromium.org/23451046/diff/1/pkg/analyzer_experimental/bin/formatter.dart File pkg/analyzer_experimental/bin/formatter.dart (right): https://codereview.chromium.org/23451046/diff/1/pkg/analyzer_experimental/bin/formatter.dart#newcode81 pkg/analyzer_experimental/bin/formatter.dart:81: .listen((String data) => input.write(data), On 2013/09/11 18:52:42, scheglov wrote: ...
7 years, 3 months ago (2013-09-11 19:02:38 UTC) #3
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-09-11 19:05:51 UTC) #4
pquitslund
7 years, 3 months ago (2013-09-11 22:36:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r27411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698