Issue 23451045: Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23451045: Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations." (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch, blois

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Convert HashSet, LinkedHashSet to factory methods and custom implementations." Triggers an error in html tests on dartium. Committed: https://code.google.com/p/dart/source/detail?r=27392

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+840 lines, -661 lines)			Patch
M	pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart	View	5 chunks	+27 lines, -27 lines	0 comments	Download
M	runtime/lib/collection_patch.dart	View	7 chunks	+688 lines, -373 lines	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View	18 chunks	+36 lines, -192 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	3 chunks	+36 lines, -46 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_set.dart	View	1 chunk	+46 lines, -4 lines	0 comments	Download
M	sdk/lib/core/list.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/hash_set_test.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/corelib/set_test.dart	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	tests/language/issue10561_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/issue9949_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r27392 (presubmit successful).

7 years, 3 months ago (2013-09-11 16:20:22 UTC) #2

blois

Looks like LinkedHashSet.clear is setting the length to 0, but new List.from(set) is getting the ...

7 years, 3 months ago (2013-09-11 16:29:08 UTC) #3

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-09-12 09:17:34 UTC) #4

Message was sent while issue was closed.

Ack, yes, the LinkedHashSet was inheriting the clear method from HashSet, so it
forgot to clear the *links*. Iteration would still find the elements (because it
traverses using the links) but the table itself was empty. Memory leak is the
least of the problems with that.

Expand Messages | Collapse Messages