Optional trailing comma support for list and map literals.

Optional trailing comma support for list and map literals.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27350

[Brian Wilkerson, 2013-09-10 18:29:51]

LGTM

[pquitslund, 2013-09-10 18:34:10]

Committed patchset #1 manually as r27350 (presubmit successful).

[kevmoo-old, 2013-09-10 18:53:23]

On 2013/09/10 18:34:10, pquitslund wrote:
> Committed patchset #1 manually as r27350 (presubmit successful).

What's the plan around flags for formatter?

While I could see some wanting trailing commas to be left in, I'd always opt to
have them removed.

[pquitslund, 2013-09-10 19:48:06]

On 2013/09/10 18:53:23, kevmoo wrote:
> On 2013/09/10 18:34:10, pquitslund wrote:
> > Committed patchset #1 manually as r27350 (presubmit successful).
> 
> What's the plan around flags for formatter?

The plan is to delay the need for flags as long as possible! :)  And when my
back is against the wall, I'll argue strongly for as few as possible.

> While I could see some wanting trailing commas to be left in, I'd always opt
to
> have them removed.

As would I.  Having said that, it's an open question as to whether this is the
formatter's job.  This might be be better handled in the editor itself by way of
style/formatting 'hints' with resolutions that perform the translation.  Anyway
(and either way), we'll want to consider other transformations (such as
translations to the short method body form, =>).

Curious where you weigh in?