Issue 23451006: Changing onCreated callback to created.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23451006: Changing onCreated callback to created. (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
Siggi Cherem (dart-lang), sra1, Jacob

CC:
reviews_dartlang.org, Jacob

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Changing onCreated callback to created. Brings it in-line with the browser's createdCallback and Polymer's created. Avoid conflict with event names. Dartium changes are https://codereview.chromium.org/23494005 BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=26754

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -22 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/attribute_changed_callback_test.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/created_callback_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom_elements_test.dart	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

blois

Committed patchset #1 manually as r26754 (presubmit successful).

7 years, 3 months ago (2013-08-27 23:51:48 UTC) #3

Message was sent while issue was closed.

lgtm