Issue 23450006: Mark test as flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23450006: Mark test as flaky. (Closed)

Created:
7 years, 3 months ago by ahe

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Mark test as flaky. Committed: https://code.google.com/p/dart/source/detail?r=26733

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	dart/tests/lib/lib.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

Committed patchset #1 manually as r26733 (presubmit successful).

7 years, 3 months ago (2013-08-27 18:12:46 UTC) #1

floitsch

7 years, 3 months ago (2013-08-28 09:20:32 UTC) #3

Message was sent while issue was closed.

LGTM.
I already started working on this, yesterday but then was side-tracked.
fyi: the issue is that the test doesn't use the async_helper.dart functionality.
It can't currently do that because we don't allow relative imports with dots
("../../async_helper.dart") in negative tests.
I'm migrating it to a package which should solve the issue.

Expand Messages | Collapse Messages