Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 23450003: Add encoding tests to pkg/http. (Closed)

Created:
7 years, 3 months ago by nweiz
Modified:
7 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add encoding tests to pkg/http. These were blocked on issue 6284. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -24 lines) Patch
M pkg/http/lib/src/request.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/http/lib/src/utils.dart View 2 chunks +27 lines, -10 lines 0 comments Download
M pkg/http/test/multipart_test.dart View 1 chunk +15 lines, -4 lines 0 comments Download
M pkg/http/test/request_test.dart View 2 chunks +30 lines, -4 lines 0 comments Download
M pkg/http/test/response_test.dart View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 3 months ago (2013-08-26 20:20:10 UTC) #1
Bob Nystrom
LGTM!
7 years, 3 months ago (2013-08-26 20:25:15 UTC) #2
nweiz
7 years, 3 months ago (2013-08-26 20:50:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26667 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698