Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 23449019: Couple of backend fixes: (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, ahe, karlklose
Visibility:
Public.

Description

Couple of backend fixes: - Remove the field check for reflection in the type inferrer to be in backend.canBeUsedForGlobalOptimizations. - Move registering of noSuchMethod helpers in backend. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=26995

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -16 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 1 chunk +1 line, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +8 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +0 lines, -3 lines 0 comments Download
A tests/compiler/dart2js_extra/mirror_type_inference_field2_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-02 07:25:39 UTC) #1
Johnni Winther
lgtm
7 years, 3 months ago (2013-09-02 08:07:52 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-02 08:17:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26995 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698