Issue 23449008: Move test failure to co19 status file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23449008: Move test failure to co19 status file (Closed)

Created:
7 years, 3 months ago by hausner

Modified:
7 years, 3 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move test failure to co19 status file Test Language/07_Classes/6_Constructors/1_Generative_Constructors_A04_t15 is wrong. Filed co19 issue 547 and updated status files. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26818

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
M	tests/co19/co19-co19.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/23449008/diff/4001/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/23449008/diff/4001/tests/co19/co19-co19.status#newcode16 tests/co19/co19-co19.status:16: Language/07_Classes/6_Constructors/1_Generative_Constructors_A04_t15: Fail # co19 issue 547 FAIL, ...

7 years, 3 months ago (2013-08-28 21:43:46 UTC) #2

hausner

7 years, 3 months ago (2013-08-28 21:57:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r26818 (presubmit successful).

Expand Messages | Collapse Messages