Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 23447007: Disble 4351 warnings on msvs compiler (Closed)

Created:
7 years, 3 months ago by ricow1
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Disble 4351 warnings on msvs compiler Chromium is actually disabling additional warnings see: http://src.chromium.org/viewvc/chrome/trunk/src/build/common.gypi?view=markup#l4447 do we want to disable any of these as well? R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=26864

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 3 months ago (2013-08-29 10:59:37 UTC) #1
Kevin Millikin (Google)
LGTM, but I'd add a comment about what the warning is and especially why we ...
7 years, 3 months ago (2013-08-29 11:24:50 UTC) #2
ricow1
On 2013/08/29 11:24:50, kmillikin wrote: > LGTM, but I'd add a comment about what the ...
7 years, 3 months ago (2013-08-29 11:27:32 UTC) #3
ricow1
7 years, 3 months ago (2013-08-29 12:22:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698