Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 23447003: Change reflective serialization rules to be able to take type literals (Closed)

Created:
7 years, 3 months ago by Alan Knight
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change reflective serialization rules to be able to take type literals R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M pkg/serialization/lib/serialization.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/serialization/lib/src/mirrors_helpers.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/serialization/test/no_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/serialization/test/serialization_test.dart View 19 chunks +27 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
Allow type literals as arguments to the addRuleFor() method, which previously required you to pass ...
7 years, 3 months ago (2013-08-26 21:37:46 UTC) #1
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-08-26 22:01:49 UTC) #2
Alan Knight
7 years, 3 months ago (2013-08-27 16:53:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26720 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698