Issue 23445016: Small changes to make analyzer happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23445016: Small changes to make analyzer happy. (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Small changes to make analyzer happy. Bool class does not contain abstract method without being abstract. Type parameter of linked list entry properly bounded, so it's a valid type parameter for linked list link. Missing default parameters values added to some StringSink methods. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=26868

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	runtime/lib/bool_patch.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sdk/lib/_collection_dev/list.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/linked_list.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/convert/string_conversion.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/core/bool.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

7 years, 3 months ago (2013-08-29 13:00:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26868 (presubmit successful).

Expand Messages | Collapse Messages