Prune the old deploy code. This CL does a few changes:

Prune the old deploy code. This CL does a few changes:
 - includes a few new steps in the deploy transforms that were missing
 - deletes emitters.dart, paths.dart (which were only needed for generating
   code), bin/dwc.dart (we never used this)
 - changes test/run.sh to run from pkg/polymer/.
 - updates tests expectations to match the new output
 - for now, disable using shadowdom-polyfill in render tests because they
   mismatch the results you'd get without the polyfill (css is changed with the
   polyfill)

R=jmesserly@google.com, terry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26828

[Siggi Cherem (dart-lang), 2013-08-27 23:30:14]

deleting code is fun!

I could keep going, but I thought this was a good place to stop doing changes. I
still need to continue deleting code from info and css, and rewrite what's left
of the compiler as a plain analyzer, but I didn't want to mix all those changes
in a single CL =)

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
File pkg/polymer/lib/src/compiler.dart (left):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
pkg/polymer/lib/src/compiler.dart:630: bool _emitAllCss() {
On a future CL I plan to go deeper in removing some of this code. I just wanted
to be more careful with deleting the css emitting code that we haven't yet
ported over.

[terry, 2013-08-28 21:37:51]

LGTM just a few questions.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart
File pkg/polymer/lib/dwc.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:33: final List<String> inputs;
Is this still needed?

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:48: var options = CompilerOptions.parse(args);
Maybe change to DeployOptions?

[Jennifer Messerly, 2013-08-28 22:25:45]

this is really cool :) few small things otherwise looks good

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/component_...
File pkg/polymer/lib/component_build.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/component_...
pkg/polymer/lib/component_build.dart:89: ..addFlag("clean", negatable: false,
help: "remove any build artifacts")
Consider: adding a note here that we don't actually produce any build artifacts,
so this is a nop

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart
File pkg/polymer/lib/dwc.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:38: AnalysisResults([this.success = true, this.inputs,
this.messages = const []]);
original had this problem too, but: these would be nice as named arguments

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
File pkg/polymer/lib/src/compiler.dart (left):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
pkg/polymer/lib/src/compiler.dart:83: var packageRoot = options.packageRoot !=
null ? options.packageRoot
we might want pkg root back now?

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
File pkg/polymer/lib/src/compiler_options.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
pkg/polymer/lib/src/compiler_options.dart:60: // TODO(sigmund): remove/deprecate
this flag
you could remove the boolean now right? but continue to parse it for now?

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/common.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/common.dart:53: if (logger != null) {
ideally we would always have a logger

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/import_inliner.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/import_inliner.dart:158: const _urlAttributes =
const [
interesting. FWIW, this is a much bigger list than the HTML Imports polyfill
supports:

https://github.com/Polymer/HTMLImports/blob/master/src/HTMLImports.js#L263

should we file a bug over there?

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/polyfill_injector.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/polyfill_injector.dart:61: '<script
type="text/javascript" '
could we leave off the type here?

[Siggi Cherem (dart-lang), 2013-08-28 23:17:05]

Thanks,

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/component_...
File pkg/polymer/lib/component_build.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/component_...
pkg/polymer/lib/component_build.dart:89: ..addFlag("clean", negatable: false,
help: "remove any build artifacts")
On 2013/08/28 22:25:45, John Messerly wrote:
> Consider: adding a note here that we don't actually produce any build
artifacts,
> so this is a nop

Done.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart
File pkg/polymer/lib/dwc.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:33: final List<String> inputs;
On 2013/08/28 21:37:56, terry wrote:
> Is this still needed?

nope, removed.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:38: AnalysisResults([this.success = true, this.inputs,
this.messages = const []]);
On 2013/08/28 22:25:45, John Messerly wrote:
> original had this problem too, but: these would be nice as named arguments

now that inputs is gone, I made them all mandatory. Done.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/dwc.dart#n...
pkg/polymer/lib/dwc.dart:48: var options = CompilerOptions.parse(args);
On 2013/08/28 21:37:56, terry wrote:
> Maybe change to DeployOptions?

I'll wait on this one. These options are currently only for the analyzer, so
maybe they'll become 'AnalyzerOptions', but we might get rid of it once we clean
up everything up.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
File pkg/polymer/lib/src/compiler.dart (left):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
pkg/polymer/lib/src/compiler.dart:83: var packageRoot = options.packageRoot !=
null ? options.packageRoot
On 2013/08/28 22:25:45, John Messerly wrote:
> we might want pkg root back now?

Done.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
File pkg/polymer/lib/src/compiler_options.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/compil...
pkg/polymer/lib/src/compiler_options.dart:60: // TODO(sigmund): remove/deprecate
this flag
On 2013/08/28 22:25:45, John Messerly wrote:
> you could remove the boolean now right? but continue to parse it for now?

Done.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/common.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/common.dart:53: if (logger != null) {
On 2013/08/28 22:25:45, John Messerly wrote:
> ideally we would always have a logger

ok, reverted this change.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/import_inliner.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/import_inliner.dart:158: const _urlAttributes =
const [
On 2013/08/28 22:25:45, John Messerly wrote:
> interesting. FWIW, this is a much bigger list than the HTML Imports polyfill
> supports:
> 
> https://github.com/Polymer/HTMLImports/blob/master/src/HTMLImports.js#L263
> 
> should we file a bug over there?

good point, totally.

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/polyfill_injector.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/polyfill_injector.dart:61: '<script
type="text/javascript" '
On 2013/08/28 22:25:45, John Messerly wrote:
> could we leave off the type here?

Done.

[Jennifer Messerly, 2013-08-28 23:25:27]

lgtm

[Siggi Cherem (dart-lang), 2013-08-28 23:36:34]

thx

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
File pkg/polymer/lib/src/transform/import_inliner.dart (right):

https://codereview.chromium.org/23445009/diff/3001/pkg/polymer/lib/src/transf...
pkg/polymer/lib/src/transform/import_inliner.dart:158: const _urlAttributes =
const [
On 2013/08/28 23:17:06, Siggi Cherem (dart-lang) wrote:
> On 2013/08/28 22:25:45, John Messerly wrote:
> > interesting. FWIW, this is a much bigger list than the HTML Imports polyfill
> > supports:
> > 
> > https://github.com/Polymer/HTMLImports/blob/master/src/HTMLImports.js#L263
> > 
> > should we file a bug over there?
> 
> good point, totally. 

filed here: https://github.com/Polymer/HTMLImports/issues/32

[Siggi Cherem (dart-lang), 2013-08-29 00:07:24]

Committed patchset #4 manually as r26828 (presubmit successful).