Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23445005: Fixing stack traces on IE10. (Closed)

Created:
7 years, 3 months ago by blois
Modified:
7 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing stack traces on IE10. BUG= R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26735

Patch Set 1 #

Patch Set 2 : Merging IE parsing into V8 parsing #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pkg/stack_trace/lib/src/trace.dart View 1 2 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
Comments say that IE's traces match V8's, but on my IE9 & IE10 I'm seeing ...
7 years, 3 months ago (2013-08-27 17:52:48 UTC) #1
nweiz
https://codereview.chromium.org/23445005/diff/4001/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (left): https://codereview.chromium.org/23445005/diff/4001/pkg/stack_trace/lib/src/trace.dart#oldcode117 pkg/stack_trace/lib/src/trace.dart:117: : this.parseV8(trace); This should be retained. https://codereview.chromium.org/23445005/diff/4001/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart ...
7 years, 3 months ago (2013-08-27 18:16:01 UTC) #2
blois
https://codereview.chromium.org/23445005/diff/4001/pkg/stack_trace/lib/src/trace.dart File pkg/stack_trace/lib/src/trace.dart (left): https://codereview.chromium.org/23445005/diff/4001/pkg/stack_trace/lib/src/trace.dart#oldcode117 pkg/stack_trace/lib/src/trace.dart:117: : this.parseV8(trace); On 2013/08/27 18:16:06, nweiz wrote: > This ...
7 years, 3 months ago (2013-08-27 18:20:30 UTC) #3
nweiz
lgtm
7 years, 3 months ago (2013-08-27 18:33:23 UTC) #4
blois
7 years, 3 months ago (2013-08-27 18:35:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r26735 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698