Make async stream test less flaky.

Make async stream test less flaky.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26923

[floitsch, 2013-08-30 13:20:01]

This should remove flakes like in
http://build.chromium.org/p/client.dart/builders/vm-mac-debug/builds/11717/st...

[kustermann, 2013-08-30 13:49:49]

Is it correct that you use the unittest framework (which is asynchronous by
nature) to test async APIs?

https://codereview.chromium.org/23444026/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_async_test.dart (right):

https://codereview.chromium.org/23444026/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:661: .then((_) {
If you have these callbacks here, don't you have to wrap them with
'expectAsync1()' et. al. to make sure they'll actually be called.

[floitsch, 2013-08-30 15:23:05]

Yes. unfortunately we use the unittest framework in some places.

https://codereview.chromium.org/23444026/diff/1/tests/lib/async/stream_contro...
File tests/lib/async/stream_controller_async_test.dart (right):

https://codereview.chromium.org/23444026/diff/1/tests/lib/async/stream_contro...
tests/lib/async/stream_controller_async_test.dart:661: .then((_) {
On 2013/08/30 13:49:49, kustermann wrote:
> If you have these callbacks here, don't you have to wrap them with
> 'expectAsync1()' et. al. to make sure they'll actually be called.

No. The `done` above makes sure that the framework waits until we are done.

[kustermann, 2013-08-30 15:45:23]

LGTM

[floitsch, 2013-08-30 15:53:30]

Committed patchset #1 manually as r26923 (presubmit successful).