Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 23444018: Revert "Enable type inference when using mirrors." (Closed)

Created:
7 years, 3 months ago by karlklose
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Enable type inference when using mirrors." This reverts commit r26882. TBR=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -46 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/compiler/dart2js_extra/mirror_type_inference_field_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/compiler/dart2js_extra/mirror_type_inference_function_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karlklose
Committed patchset #1 manually as r26884 (presubmit successful).
7 years, 3 months ago (2013-08-29 18:02:36 UTC) #1
ngeoffray
7 years, 3 months ago (2013-08-30 06:35:22 UTC) #2
Message was sent while issue was closed.
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698