Added tools/signing_script.py, used to automate steps before and after the signing step

Added tools/signing_script.py, used to automate steps before and after the signing step

The signing itself is still a manual process, this script only automates the
steps before and after signing to minimize the manual work.

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28585

[kustermann, 2013-09-11 08:23:18]

First round of comments -- ignore the long lines for now.

[ricow1, 2013-09-11 11:09:57]

The actual functionality LGTM, I think a few refactorings will make this easier
to read/maintain

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py
File dart/tools/signing_script.py (right):

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:85: def drun(command):
Remove, or actually add an option called --dry-run and call this from run? (and
rename to dryrun

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:88: def clean_directory(directory):
add comment explaining why we don't use the build in python shutil methods

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:111: if not options.scratch_dir:
validate that we are running on linux, this will not work otherwise (maybe on
mac)

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:156: editor_from = os.path.join(destination_dir,
'dart', 'DartEditor.app')
If you add either "postfix": ".exe" or ".app" to config depending on the system
you can unify a lot here. With a comment explaining why we zip on mac and just
copy on windows this should be smaller an easier to read (bonus points for
extracting it to a function)

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:174: 
Please elaborate on the difference here, for windows we just expect an exe file
and on mac we require a zip of the app dir I expect

https://codereview.chromium.org/23442023/diff/1/dart/tools/signing_script.py#...
dart/tools/signing_script.py:196: editor_from = os.path.join(postsign_dir,
'DartEditor%(bits)s.app' % config)
same comment as above, I think this would look much nicer if you extracted this
into two functions, prepare and deploy, giving the config and buckets

[kustermann, 2013-10-14 12:18:38]

PTAL

[ricow1, 2013-10-14 13:23:45]

LGTM

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py
File tools/signing_script.py (right):

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py#ne...
tools/signing_script.py:119: def unzip_and_copy(from_dir, to_dir, postsign_dir):
as discussed offline, the parameter names here could be better, it is pretty
hard to follow. At least add a comment specifying how this is structured

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py#ne...
tools/signing_script.py:129: def upload_to_old_location(config, source_zip):
this is a little late now - we should have filed a bug to track all the places
we can retire when we remove the old buckets

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py#ne...
tools/signing_script.py:246: # Download *.zip files from GCS buckets
I think all of this would be more readable if you extracted the two branches
into individual functions

[kustermann, 2013-10-14 16:05:31]

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py
File tools/signing_script.py (right):

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py#ne...
tools/signing_script.py:119: def unzip_and_copy(from_dir, to_dir, postsign_dir):
On 2013/10/14 13:23:46, ricow1 wrote:
> as discussed offline, the parameter names here could be better, it is pretty
> hard to follow. At least add a comment specifying how this is structured

Done.

https://codereview.chromium.org/23442023/diff/8001/tools/signing_script.py#ne...
tools/signing_script.py:129: def upload_to_old_location(config, source_zip):
On 2013/10/14 13:23:46, ricow1 wrote:
> this is a little late now - we should have filed a bug to track all the places
> we can retire when we remove the old buckets

It's not that many places we have, so I guess it's okay.

[kustermann, 2013-10-14 16:11:00]

Committed patchset #3 manually as r28585 (presubmit successful).