Issue 23441054: one-liners for a few polymer-related libraries

Issue 23441054: one-liners for a few polymer-related libraries (Closed)

Created:
7 years, 3 months ago by Kathy Walrath

Modified:
7 years, 3 months ago

Reviewers:
Jennifer Messerly, mem

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

one-liners for a few polymer-related libraries R=jmesserly@google.com, mcampione@google.com Committed: https://code.google.com/p/dart/source/detail?r=27500

Patch Set 3 : incorporate review comments #

Patch Set 5 : tweak #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -7 lines)			Patch
M	pkg/custom_element/lib/custom_element.dart	View	1 2 3	1 chunk	+11 lines, -4 lines	0 comments	Download
M	pkg/mdv/lib/mdv.dart	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	pkg/observe/lib/observe.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Kathy Walrath

Hi, there. I edited these libraries to have consistent descriptions, starting with a one-line noun ...

7 years, 3 months ago (2013-09-11 16:56:09 UTC) #1

Jennifer Messerly

https://chromiumcodereview.appspot.com/23441054/diff/3001/pkg/custom_element/lib/custom_element.dart File pkg/custom_element/lib/custom_element.dart (right): https://chromiumcodereview.appspot.com/23441054/diff/3001/pkg/custom_element/lib/custom_element.dart#newcode14 pkg/custom_element/lib/custom_element.dart:14: * [Polymer.dart homepage](http://www.dartlang.org/polymer-dart/). actually, suggestion: link to https://www.dartlang.org/polymer-dart/#custom-elements

7 years, 3 months ago (2013-09-11 19:51:16 UTC) #3

mem

one question about capitalizing. otherwise, lgtm. https://codereview.chromium.org/23441054/diff/3001/pkg/custom_element/lib/custom_element.dart File pkg/custom_element/lib/custom_element.dart (right): https://codereview.chromium.org/23441054/diff/3001/pkg/custom_element/lib/custom_element.dart#newcode11 pkg/custom_element/lib/custom_element.dart:11: * API, which ...

7 years, 3 months ago (2013-09-11 20:05:46 UTC) #4

Kathy Walrath

Made those changes. I'll assume the lgtm holds unless you say differently soon... https://codereview.chromium.org/23441054/diff/3001/pkg/custom_element/lib/custom_element.dart File ...

7 years, 3 months ago (2013-09-11 20:37:25 UTC) #5

Kathy Walrath

7 years, 3 months ago (2013-09-13 20:25:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r27500 (presubmit successful).

Expand Messages | Collapse Messages