Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 23441007: Directory processing for the formatter main. (Closed)

Created:
7 years, 3 months ago by pquitslund
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M pkg/analyzer_experimental/bin/formatter.dart View 1 2 3 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pquitslund
7 years, 3 months ago (2013-08-27 22:39:33 UTC) #1
Brian Wilkerson
LGTM
7 years, 3 months ago (2013-08-27 23:09:11 UTC) #2
scheglov
LGTM https://codereview.chromium.org/23441007/diff/3001/pkg/analyzer_experimental/bin/formatter.dart File pkg/analyzer_experimental/bin/formatter.dart (right): https://codereview.chromium.org/23441007/diff/3001/pkg/analyzer_experimental/bin/formatter.dart#newcode67 pkg/analyzer_experimental/bin/formatter.dart:67: _isDartFile(file) => !file.path.startsWith('.') && file.path.endsWith(DART_EXT); Ignore case?
7 years, 3 months ago (2013-08-27 23:17:20 UTC) #3
pquitslund
On 2013/08/27 23:17:20, scheglov wrote: > LGTM > > https://codereview.chromium.org/23441007/diff/3001/pkg/analyzer_experimental/bin/formatter.dart > File pkg/analyzer_experimental/bin/formatter.dart (right): > ...
7 years, 3 months ago (2013-08-28 17:49:58 UTC) #4
pquitslund
7 years, 3 months ago (2013-08-28 17:51:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r26805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698