Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 23440018: Disable all warnings when compiling NSS. (Closed)

Created:
7 years, 3 months ago by Bill Hesse
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Disable all warnings when compiling NSS. Disabling individual warnings when compiling NSS no longer works, because some warnings that cannot be disabled individually are now generated. BUG=dartbug.com/13064 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27190

Patch Set 1 #

Patch Set 2 : Add XCode fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M runtime/tools/gyp/nss_configurations.gypi View 1 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bill Hesse
Some NSS compilation warnings cannot be disabled individually, so we must use -w to make ...
7 years, 3 months ago (2013-09-05 09:24:51 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-09-05 09:32:10 UTC) #2
Bill Hesse
Added a -w flag to the xcode build.
7 years, 3 months ago (2013-09-05 10:56:26 UTC) #3
Søren Gjesse
lgtm How about Android?
7 years, 3 months ago (2013-09-05 10:57:40 UTC) #4
Bill Hesse
On 2013/09/05 10:57:40, Søren Gjesse wrote: > lgtm > > How about Android? We don't ...
7 years, 3 months ago (2013-09-05 11:07:34 UTC) #5
Bill Hesse
7 years, 3 months ago (2013-09-05 11:09:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r27190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698