Improved comment handling (and misc. formatter fixes).

Improved comment handling (and misc. formatter fixes).

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26746

[pquitslund, 2013-08-27 20:31:01]

Not fully settled on method names and another round of general cleanup to come
but this gets us a lot of the way closer to supporting comments in their various
forms.  If there are test cases that come to mind, I'm all ears.

Thanks! :)

[Brian Wilkerson, 2013-08-27 21:12:45]

LGTM

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:1163:
linesBetween(comment.offset, comment.end) <= 1;
Can this ever legitimately be 1, or should this test just be "< 1"?

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/test/services/formatter_test.dart:361:
expectCUFormatsTo(
Related to my earlier questions, what happens if the end-of-line comment
precedes the block comment? Or if the comment is at the end of the file? For
example:

library foo;


/* Comment 1 */


// Comment 2


/* Comment 3 */

[pquitslund, 2013-08-27 21:55:37]

Thanks!

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:1163:
linesBetween(comment.offset, comment.end) <= 1;
On 2013/08/27 21:12:45, Brian Wilkerson wrote:
> Can this ever legitimately be 1, or should this test just be "< 1"?

I think not.  Fixed!

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/23440011/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/test/services/formatter_test.dart:361:
expectCUFormatsTo(
On 2013/08/27 21:12:45, Brian Wilkerson wrote:
> Related to my earlier questions, what happens if the end-of-line comment
> precedes the block comment? Or if the comment is at the end of the file? For
> example:
> 
> library foo;
> 
> 
> /* Comment 1 */
> 
> 
> // Comment 2
> 
> 
> /* Comment 3 */

Predictably this breaks.  Thanks for the catch.  Sine the fix requires a little
rejiggering, I'll follow-up with another CL.

[pquitslund, 2013-08-27 21:56:02]

Committed patchset #3 manually as r26746 (presubmit successful).