JSON string decoding for VM debugger

JSON string decoding for VM debugger

The VM must properly decode JSON strings it receives.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26668

[regis, 2013-08-26 20:12:24]

LGTM

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc
File runtime/platform/json.cc (right):

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:405: intptr_t max = buflen - 1;
const

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:422: intptr_t max = buflen - 1;
const

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:422: intptr_t max = buflen - 1;
How about last_idx instead of max?

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:423: intptr_t value_len = ValueLen();
const

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:430: buf[buf_idx] = ch;
You could move this buf[buf_idx] = ch to an else part and to the default case,
as to not write twice into the same location.

[hausner, 2013-08-26 20:57:40]

Thank you.

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc
File runtime/platform/json.cc (right):

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:405: intptr_t max = buflen - 1;
On 2013/08/26 20:12:24, regis wrote:
> const

Not in this case, unless I initialize it as min(buflen-1, ValueLen()).

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:422: intptr_t max = buflen - 1;
On 2013/08/26 20:12:24, regis wrote:
> const

Done.

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:422: intptr_t max = buflen - 1;
On 2013/08/26 20:12:24, regis wrote:
> const

Done.

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:423: intptr_t value_len = ValueLen();
On 2013/08/26 20:12:24, regis wrote:
> const

Done.

https://codereview.chromium.org/23439002/diff/1/runtime/platform/json.cc#newc...
runtime/platform/json.cc:430: buf[buf_idx] = ch;
On 2013/08/26 20:12:24, regis wrote:
> You could move this buf[buf_idx] = ch to an else part and to the default case,
> as to not write twice into the same location.
True. OTOH I find it a bit more readable like this and the only characters that
cause two writes are escaped characters. If you feel strongly about it I can
revisit it in a follow-up change.

[hausner, 2013-08-26 20:59:20]

Committed patchset #1 manually as r26668 (presubmit successful).