Issue 23437044: co19-roll to r587

Issue 23437044: co19-roll to r587 (Closed)

Created:
7 years, 3 months ago by kustermann

Modified:
7 years, 3 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

co19-roll to r587 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=27657

Patch Set 5 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -309 lines)			Patch
M	dart/tests/co19/co19-analyzer.status	View	1	3 chunks	+5 lines, -131 lines	0 comments	Download
M	dart/tests/co19/co19-analyzer2.status	View	1 2	4 chunks	+4 lines, -85 lines	0 comments	Download
M	dart/tests/co19/co19-co19.status	View	1 2 3	4 chunks	+3 lines, -12 lines	0 comments	Download
M	dart/tests/co19/co19-dart2dart.status	View	1 2 3	4 chunks	+4 lines, -5 lines	0 comments	Download
M	dart/tests/co19/co19-dart2js.status	View	1 2 3 4	10 chunks	+35 lines, -34 lines	0 comments	Download
M	dart/tests/co19/co19-runtime.status	View		2 chunks	+3 lines, -34 lines	0 comments	Download
M	dart/tools/testing/dart/co19_test.dart	View	1 2 3	2 chunks	+10 lines, -6 lines	0 comments	Download
M	deps/all.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	deps/standalone.deps/DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/23437044/diff/11001/dart/tests/co19/co19-dart2js.status File dart/tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/23437044/diff/11001/dart/tests/co19/co19-dart2js.status#newcode659 dart/tests/co19/co19-dart2js.status:659: [ $compiler == dart2js || $compiler == dart2dart] ...

7 years, 3 months ago (2013-09-19 11:16:25 UTC) #2

kustermann

https://codereview.chromium.org/23437044/diff/11001/dart/tests/co19/co19-dart2js.status File dart/tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/23437044/diff/11001/dart/tests/co19/co19-dart2js.status#newcode659 dart/tests/co19/co19-dart2js.status:659: [ $compiler == dart2js || $compiler == dart2dart] On ...

7 years, 3 months ago (2013-09-19 11:23:45 UTC) #3

kustermann

7 years, 3 months ago (2013-09-19 11:51:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r27657 (presubmit successful).

Expand Messages | Collapse Messages