Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 23437008: Added one-liner and "other resources" for dart:html library description (Closed)

Created:
7 years, 3 months ago by mem
Modified:
7 years, 3 months ago
Visibility:
Public.

Description

Added one-liner and "other resources" for dart:html library description BUG= R=blois@google.com, efortuna@google.com, kathyw@google.com Committed: https://code.google.com/p/dart/source/detail?r=26870

Patch Set 1 #

Patch Set 2 : corrected a link and tweaked wording #

Total comments: 10

Patch Set 3 : incorporated review comments #

Patch Set 4 : generated dartium version #

Patch Set 5 : minor tweak, merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -23 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +24 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +27 lines, -8 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 3 4 1 chunk +24 lines, -5 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 3 4 1 chunk +24 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mem
Hi there: I've added a brief description of the dart:html library and included some links ...
7 years, 3 months ago (2013-08-28 12:59:08 UTC) #1
Kathy Walrath
https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart#newcode5 sdk/lib/html/dart2js/html_dart2js.dart:5: + * This library includes DOM element types, CSS ...
7 years, 3 months ago (2013-08-28 14:43:11 UTC) #2
blois
lgtm https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dartium/html_dartium.dart#oldcode26104 sdk/lib/html/dartium/html_dartium.dart:26104: - if ((blob_OR_source_OR_stream is MediaSource || blob_OR_source_OR_stream == ...
7 years, 3 months ago (2013-08-28 15:59:06 UTC) #3
Emily Fortuna
https://codereview.chromium.org/23437008/diff/3001/tools/dom/templates/html/dart2js/html_dart2js.darttemplate File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right): https://codereview.chromium.org/23437008/diff/3001/tools/dom/templates/html/dart2js/html_dart2js.darttemplate#newcode10 tools/dom/templates/html/dart2js/html_dart2js.darttemplate:10: * Resources, including HTML elements, for web-based applications that ...
7 years, 3 months ago (2013-08-28 17:45:16 UTC) #4
Emily Fortuna
ignore my last comment. I wasn't looking at the file names correctly. lgtm
7 years, 3 months ago (2013-08-28 18:10:49 UTC) #5
mem
Thanks for your comments. mem https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/23437008/diff/3001/sdk/lib/html/dart2js/html_dart2js.dart#newcode5 sdk/lib/html/dart2js/html_dart2js.dart:5: + * This library ...
7 years, 3 months ago (2013-08-29 11:41:52 UTC) #6
Kathy Walrath
lgtm
7 years, 3 months ago (2013-08-29 12:05:09 UTC) #7
mem
7 years, 3 months ago (2013-08-29 14:28:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r26870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698