Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 23437007: Remember metadata positions for mixin and function typedefs. (Closed)

Created:
7 years, 3 months ago by rmacnak
Modified:
7 years, 3 months ago
Reviewers:
hausner, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe, Michael Lippautz (Google)
Visibility:
Public.

Description

Remember metadata positions for mixin and function typedefs. BUG=http://dartbug.com/10906 R=asiva@google.com, hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=26680

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M runtime/vm/parser.h View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 5 chunks +12 lines, -4 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/typedef_metadata_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 3 months ago (2013-08-26 23:21:36 UTC) #1
hausner
lgtm
7 years, 3 months ago (2013-08-26 23:36:47 UTC) #2
siva
lgtm
7 years, 3 months ago (2013-08-27 00:32:20 UTC) #3
rmacnak
7 years, 3 months ago (2013-08-27 00:47:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698