Issue 23436005: Add library tag to web_socket_ping_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23436005: Add library tag to web_socket_ping_test. (Closed)

Created:
7 years, 3 months ago by Anders Johnsen

Modified:
7 years, 3 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add library tag to web_socket_ping_test. BUG= Committed: https://code.google.com/p/dart/source/detail?r=27000

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tests/standalone/io/web_socket_ping_test.dart	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #1 manually as r27000 (presubmit successful).

7 years, 3 months ago (2013-09-02 08:58:11 UTC) #3

Søren Gjesse

7 years, 3 months ago (2013-09-02 10:04:11 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/23436005/diff/1/tests/standalone/io/web_socke...
File tests/standalone/io/web_socket_ping_test.dart (right):

https://codereview.chromium.org/23436005/diff/1/tests/standalone/io/web_socke...
tests/standalone/io/web_socket_ping_test.dart:10: library dart.io;
Hack, hack, ... maybe add a comment.

Expand Messages | Collapse Messages