Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 23431010: Change in deploy.dart to make it easier to run in run.sh without running pub. (Closed)

Created:
7 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 3 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change in deploy.dart to make it easier to run in run.sh without running pub. You probably will delete some of this, but wanted to have things working better. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26900

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -69 lines) Patch
A + pkg/observe/lib/html.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/observe/lib/observe_html.dart View 1 1 chunk +0 lines, -63 lines 0 comments Download
M pkg/polymer/lib/deploy.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/polymer/lib/polymer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/run.sh View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-08-29 02:17:02 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/23431010/diff/1/pkg/observe/lib/observe_html.dart File pkg/observe/lib/observe_html.dart (right): https://codereview.chromium.org/23431010/diff/1/pkg/observe/lib/observe_html.dart#newcode10 pkg/observe/lib/observe_html.dart:10: library observe_html; this should be observe.observe_html right? actually -- ...
7 years, 3 months ago (2013-08-29 18:21:24 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/23431010/diff/1/pkg/observe/lib/observe_html.dart File pkg/observe/lib/observe_html.dart (right): https://codereview.chromium.org/23431010/diff/1/pkg/observe/lib/observe_html.dart#newcode13 pkg/observe/lib/observe_html.dart:13: import 'package:observe/observe.dart'; On 2013/08/29 18:21:24, John Messerly wrote: > ...
7 years, 3 months ago (2013-08-30 00:00:41 UTC) #3
Jennifer Messerly
lgtm
7 years, 3 months ago (2013-08-30 01:57:41 UTC) #4
Siggi Cherem (dart-lang)
7 years, 3 months ago (2013-08-30 02:00:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r26900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698