Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 23428002: Fix android compilation by copying process_linux.cc to process_android.cc. (Closed)

Created:
7 years, 3 months ago by Bill Hesse
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix android compilation by copying process_linux.cc to process_android.cc. These files, in runtime/bin, are the native functions supporting the dart:io Process class. The android version hadn't been updated when the linux version was changed. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -16 lines) Patch
M runtime/bin/process_android.cc View 4 chunks +127 lines, -13 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 3 months ago (2013-08-26 12:16:50 UTC) #1
Søren Gjesse
lgtm
7 years, 3 months ago (2013-08-26 12:19:59 UTC) #2
Bill Hesse
7 years, 3 months ago (2013-08-26 12:28:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698