Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 23414005: Create json package. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't use dart:convert. #

Total comments: 4

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
A pkg/json/README.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + pkg/json/lib/json.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
A pkg/json/pubspec.yaml View 1 chunk +9 lines, -0 lines 0 comments Download
A + pkg/json/test/json_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
Make json package.
7 years, 3 months ago (2013-08-26 13:42:04 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 3 months ago (2013-08-26 13:53:45 UTC) #2
floitsch
PTAL. I changed to not forward to the internal json library. This makes it slower, ...
7 years, 3 months ago (2013-08-26 14:01:21 UTC) #3
Lasse Reichstein Nielsen
LGTM. I think having parse/stringify use the local library is perfectly fine. It should be ...
7 years, 3 months ago (2013-08-27 10:06:19 UTC) #4
floitsch
https://codereview.chromium.org/23414005/diff/5001/pkg/json/README.md File pkg/json/README.md (right): https://codereview.chromium.org/23414005/diff/5001/pkg/json/README.md#newcode4 pkg/json/README.md:4: is (in its original form) a copy of the ...
7 years, 3 months ago (2013-08-27 11:51:02 UTC) #5
floitsch
7 years, 3 months ago (2013-08-27 11:52:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r26708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698