Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 23414004: Add dart:io tests for creating a client and server in separate processes. (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add dart:io tests for creating a client and server in separate processes. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26628

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -0 lines) Patch
A tests/standalone/io/http_cross_process_test.dart View 1 chunk +60 lines, -0 lines 1 comment Download
A tests/standalone/io/raw_socket_cross_process_test.dart View 1 chunk +72 lines, -0 lines 0 comments Download
A tests/standalone/io/socket_cross_process_test.dart View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 4 months ago (2013-08-26 09:15:23 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/23414004/diff/1/tests/standalone/io/http_cross_process_test.dart File tests/standalone/io/http_cross_process_test.dart (right): https://codereview.chromium.org/23414004/diff/1/tests/standalone/io/http_cross_process_test.dart#newcode41 tests/standalone/io/http_cross_process_test.dart:41: ..add('client') Should it be --client ? (for all ...
7 years, 4 months ago (2013-08-26 09:25:57 UTC) #2
Bill Hesse
7 years, 4 months ago (2013-08-26 09:33:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698