Issue 23410002: Fix issue 12718 - crash when the trying to access context variables in a frame.

Issue 23410002: Fix issue 12718 - crash when the trying to access context variables in a frame. (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 12718 - crash when the trying to access context variables in a frame. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=26658

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	runtime/vm/debugger.cc	View	1	1 chunk	+16 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://codereview.chromium.org/23410002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/23410002/diff/1/runtime/vm/debugger.cc#newcode540 runtime/vm/debugger.cc:540: } else { Maybe add a comment here ...

7 years, 3 months ago (2013-08-26 15:27:48 UTC) #2

siva

https://codereview.chromium.org/23410002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/23410002/diff/1/runtime/vm/debugger.cc#newcode540 runtime/vm/debugger.cc:540: } else { Created an issue https://code.google.com/p/dart/issues/detail?id=12767 and added ...

7 years, 3 months ago (2013-08-26 16:55:39 UTC) #3

siva

7 years, 3 months ago (2013-08-26 17:06:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26658 (presubmit successful).

Expand Messages | Collapse Messages