Issue 233793002: Remove _LocationWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233793002: Remove _LocationWrapper (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove _LocationWrapper Use dispatch tags to avoid touching Location.prototype instead of wrapping. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34946

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -248 lines)			Patch
M	sdk/lib/_internal/lib/native_helper.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+5 lines, -123 lines	0 comments	Download
D	tools/dom/src/dart2js_LocationWrapper.dart	View		1 chunk	+0 lines, -89 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1	1 chunk	+5 lines, -35 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://chromiumcodereview.appspot.com/233793002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://chromiumcodereview.appspot.com/233793002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#oldcode27480 sdk/lib/html/dart2js/html_dart2js.dart:27480: Location get location { => _location?

6 years, 8 months ago (2014-04-10 21:31:14 UTC) #2

sra1

6 years, 8 months ago (2014-04-10 21:45:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r34946 (presubmit successful).

Expand Messages | Collapse Messages

Issue 233793002: Remove _LocationWrapper (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages