Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 23368003: Cleanup of isolate.status (first step) (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
Reviewers:
ricow1, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup of isolate.status (first step) R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26506

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -255 lines) Patch
A + tests/isolate/browser/compute_this_script_browser_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/isolate/browser/compute_this_script_browser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/isolate/browser/ports_compilation_browser_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/isolate/browser/typed_data_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/isolate/compute_this_script_browser_stream_test.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D tests/isolate/compute_this_script_browser_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M tests/isolate/isolate.status View 4 chunks +15 lines, -27 lines 4 comments Download
M tests/isolate/isolate_stress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/isolate/ports_compilation_browser_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/isolate/typed_data_message_test.dart View 1 chunk +0 lines, -97 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 5 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
I will do this in a number of steps to make it easier to follow ...
7 years, 4 months ago (2013-08-21 10:29:29 UTC) #1
Søren Gjesse
ping
7 years, 4 months ago (2013-08-22 07:03:33 UTC) #2
ricow1
Sorry for delay LGTM At first I was wondering if we should just substitute SkipByDesign ...
7 years, 4 months ago (2013-08-22 07:11:09 UTC) #3
Søren Gjesse
https://codereview.chromium.org/23368003/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://codereview.chromium.org/23368003/diff/1/tests/isolate/isolate.status#newcode14 tests/isolate/isolate.status:14: [ $compiler == none && $runtime == drt ] ...
7 years, 4 months ago (2013-08-22 07:33:25 UTC) #4
Søren Gjesse
7 years, 4 months ago (2013-08-22 07:35:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r26506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698