Issue 233673003: Deal better with missing sources in code_transformers and polymer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233673003: Deal better with missing sources in code_transformers and polymer (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 8 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deal better with missing sources in code_transformers and polymer R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34978

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	pkg/code_transformers/lib/src/resolver_impl.dart	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
	M	pkg/polymer/lib/src/build/script_compactor.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/233673003/diff/1/pkg/code_transformers/lib/src/resolver_impl.dart File pkg/code_transformers/lib/src/resolver_impl.dart (right): https://codereview.chromium.org/233673003/diff/1/pkg/code_transformers/lib/src/resolver_impl.dart#newcode140 pkg/code_transformers/lib/src/resolver_impl.dart:140: transform.logger.warning('Asset not found: $assetId'); we already compute the span ...

6 years, 8 months ago (2014-04-10 20:05:46 UTC) #1

Siggi Cherem (dart-lang)

PTAL - just adding the null checks as we discussed, and we'll work on improving ...

6 years, 8 months ago (2014-04-11 16:06:50 UTC) #2

Siggi Cherem (dart-lang)

6 years, 8 months ago (2014-04-11 16:15:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34978 (presubmit successful).

Expand Messages | Collapse Messages

Issue 233673003: Deal better with missing sources in code_transformers and polymer (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages