Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 23361011: De-flaking custom element test. (Closed)

Created:
7 years, 4 months ago by blois
Modified:
7 years, 4 months ago
Reviewers:
ricow1, Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

De-flaking custom element test. This appears to be the Chrome flakiness around making XHRs. BUG=12592 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tests/html/custom_elements_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 4 months ago (2013-08-21 16:56:23 UTC) #1
Emily Fortuna
lgtm. can we close out issue 12592 since it's the caching issue?
7 years, 4 months ago (2013-08-21 16:58:16 UTC) #2
blois
7 years, 4 months ago (2013-08-21 17:43:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26447 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698