Issue 233473002: Limit shrinkage: allow growth by at least half the pages freed by GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233473002: Limit shrinkage: allow growth by at least half the pages freed by GC. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Limit shrinkage: allow growth by at least half the pages freed by GC. R=iposva@google.com BUG=18147 Committed: https://code.google.com/p/dart/source/detail?r=35145

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	runtime/vm/pages.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

koda

Actually, we might want to postpone this change until we better handle the large object ...

6 years, 8 months ago (2014-04-10 19:31:19 UTC) #2

koda

Updated the CL to address the shrinkage issue, which is especially problematic for large objects. ...

6 years, 8 months ago (2014-04-10 22:07:44 UTC) #3

koda

Committed patchset #2 manually as r35145 (presubmit successful).

6 years, 8 months ago (2014-04-17 17:06:53 UTC) #5

koda

6 years, 8 months ago (2014-04-17 17:23:15 UTC) #6

Message was sent while issue was closed.

For the record, this fixes issue dart:18147 (Frequently Mark-Sweep close to each
other).