Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 23334003: Mark co19 tests as flaky. (Closed)

Created:
7 years, 4 months ago by floitsch
Modified:
7 years, 4 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove 'flaky' comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/co19/co19-co19.status View 1 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
7 years, 4 months ago (2013-08-21 11:07:26 UTC) #1
ricow1
LGTM why the flaky word in the comment
7 years, 4 months ago (2013-08-21 11:11:17 UTC) #2
floitsch
On 2013/08/21 11:11:17, ricow1 wrote: > LGTM > why the flaky word in the comment ...
7 years, 4 months ago (2013-08-21 11:35:52 UTC) #3
floitsch
Committed patchset #2 manually as r26424 (presubmit successful).
7 years, 4 months ago (2013-08-21 11:36:17 UTC) #4
Ivan Posva
https://codereview.chromium.org/23334003/diff/4001/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/23334003/diff/4001/tests/co19/co19-co19.status#newcode67 tests/co19/co19-co19.status:67: LibTest/isolate_api/streamSpawnFunction_A02_t02: Pass, Fail # co19 issue 540 "FAIL, OK" ...
7 years, 4 months ago (2013-08-22 00:58:06 UTC) #5
ricow1
7 years, 4 months ago (2013-08-22 05:40:26 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/23334003/diff/4001/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/23334003/diff/4001/tests/co19/co19-co19.statu...
tests/co19/co19-co19.status:67: LibTest/isolate_api/streamSpawnFunction_A02_t02:
Pass, Fail # co19 issue 540
On 2013/08/22 00:58:06, Ivan Posva wrote:
> "FAIL, OK" as we are not intending to fix the bug that these tests uncovered?
In that case, "Pass, Fail, OK"

Powered by Google App Engine
This is Rietveld 408576698