Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 233233002: Copy types object when using a cached compiler. (Closed)

Created:
6 years, 8 months ago by ahe
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose
Visibility:
Public.

Description

Copy types object when using a cached compiler. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=34927

Patch Set 1 : #

Total comments: 3

Patch Set 2 : Found issue during test, added comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -27 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 chunk +15 lines, -12 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M dart/tests/compiler/dart2js/memory_compiler.dart View 1 2 chunks +22 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js/message_kind_test.dart View 1 chunk +6 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ahe
6 years, 8 months ago (2014-04-10 13:44:25 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart File dart/tests/compiler/dart2js/memory_compiler.dart (right): https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart#newcode197 dart/tests/compiler/dart2js/memory_compiler.dart:197: cachedCompiler.scanner = null; Add a comment about why ...
6 years, 8 months ago (2014-04-10 13:51:55 UTC) #2
ahe
https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart File dart/tests/compiler/dart2js/memory_compiler.dart (right): https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart#newcode197 dart/tests/compiler/dart2js/memory_compiler.dart:197: cachedCompiler.scanner = null; On 2014/04/10 13:51:55, Johnni Winther wrote: ...
6 years, 8 months ago (2014-04-10 14:02:47 UTC) #3
Johnni Winther
https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart File dart/tests/compiler/dart2js/memory_compiler.dart (right): https://codereview.chromium.org/233233002/diff/20001/dart/tests/compiler/dart2js/memory_compiler.dart#newcode197 dart/tests/compiler/dart2js/memory_compiler.dart:197: cachedCompiler.scanner = null; On 2014/04/10 14:02:48, ahe wrote: > ...
6 years, 8 months ago (2014-04-10 14:08:47 UTC) #4
ahe
PTAL
6 years, 8 months ago (2014-04-10 14:22:13 UTC) #5
Johnni Winther
lgtm
6 years, 8 months ago (2014-04-10 14:23:12 UTC) #6
ahe
6 years, 8 months ago (2014-04-10 14:26:28 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r34927 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698