Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2331833002: Switch to FolderBasedDartSdk. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M lib/src/dart_sdk.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M lib/src/resolvers.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-11 21:55:01 UTC) #1
Brian Wilkerson
lgtm. The reason I hadn't already done this though is that we've been discussing the ...
4 years, 3 months ago (2016-09-12 03:09:51 UTC) #2
Nate Bosch
lgtm
4 years, 3 months ago (2016-09-12 17:17:22 UTC) #3
scheglov
4 years, 3 months ago (2016-09-12 18:29:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1076161ff1e9dd02ce133e3560df1fef7ad2e346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698